From aa6d5f39f569f43c780ec838fb598a8cf715454e Mon Sep 17 00:00:00 2001 From: Felix Eckhofer <felix@eckhofer.com> Date: Mon, 23 Dec 2024 00:13:24 +0100 Subject: [PATCH] Fix condition empty strings aren't truthy. --- app/views/assignments/_user_avatar.html.erb | 2 +- app/views/candidates/_user_avatar.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/assignments/_user_avatar.html.erb b/app/views/assignments/_user_avatar.html.erb index 1ed5259..55e2440 100644 --- a/app/views/assignments/_user_avatar.html.erb +++ b/app/views/assignments/_user_avatar.html.erb @@ -11,7 +11,7 @@ <% end %> </button> </span> -<% if user.languages_from || user.languages_to %> +<% if !user.languages_from.blank? || !user.languages_to.blank? %> <small class="text-2xs uppercase font-light bg-black/10 rounded-sm p-1 mr-1" aria-label="Languages <%= user.name %> can translate" title="Languages <%= user.name %> can translate"> <%= user.languages_from %> <span aria-label="to">→</span> diff --git a/app/views/candidates/_user_avatar.html.erb b/app/views/candidates/_user_avatar.html.erb index 0197fff..d830330 100644 --- a/app/views/candidates/_user_avatar.html.erb +++ b/app/views/candidates/_user_avatar.html.erb @@ -12,7 +12,7 @@ <% end %> </button> </span> -<% if user.languages_from || user.languages_to %> +<% if !user.languages_from.blank? || !user.languages_to.blank? %> <small class="text-2xs uppercase font-light bg-black/10 rounded-sm p-1 ml-1"> <%= user.languages_from %> <% if user.languages_from && user.languages_to %>→<% end %> -- GitLab