Skip to content
Snippets Groups Projects

Add user-connection and proper connection teardowns

If LDAP_SERVICE_BIND_DN is empty, use the current users credentials for all LDAP actions.

The user_password is stored in the cookie for that reason.

Also, ensure teardown of all opened LDAP connection afterwards

Edited by sistason

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • nd
  • nd
  • sistason added 1 commit

    added 1 commit

    • 9b5df692 - Update ldap.py to ignore PEP8

    Compare with previous version

  • How does this interact with other functionality? I guess signup and invite won't work at all. Maybe they should be disabled somehow if LDAP_SERVICE_BIND_DN empty (e.g. by not adding the blueprints to the app in uffd/__init__.py). I can also imagine that some other things subtly break.

    I generally think there should be a list of features that we support with user-connections enabled and that are also covered by our test-suite in this configuration. The OpenLDAP tests should be relatively easy to adapt.

  • sistason added 1 commit

    added 1 commit

    • 83612f69 - ordentlich machen nach rücksprache

    Compare with previous version

  • sistason added 3 commits

    added 3 commits

    • 5ce04185 - 1 commit from branch master
    • 513f76f9 - prepare merge to main branch
    • c62b671c - Merge remote-tracking branch 'remotes/origin/master' into ldap_user_conn

    Compare with previous version

  • sistason unapproved this merge request

    unapproved this merge request

  • sistason added 1 commit

    added 1 commit

    • 0de9e6e5 - cosmetics and reorganized imports more efficiently

    Compare with previous version

  • sistason marked this merge request as draft

    marked this merge request as draft

  • sistason added 1 commit

    added 1 commit

    Compare with previous version

  • sistason added 1 commit

    added 1 commit

    • 0aaa56ec - LDAP mocking needs to be dran gedacht

    Compare with previous version

  • sistason added 1 commit
  • sistason added 1 commit

    added 1 commit

    • a363d4a1 - started with unittests, but stuck on a mock issue

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading