Naming in LDAP protocol classes
Class/instance attributes and enum values are mostly named after the ASN.1 descriptions used in RFC4511. This is not consistent (e.g. in the Filter classes). Also the names from the ASN.1 descriptions are pretty ugly in some cases (e.g. ModifyDNRequest.deleteoldrdn
) and generally inconsistent with the rest of the codebase (cameCase in place of snake_style for attributes and cameCase in place of UPPER_CASE in enum values).
-
Decide on whether to stick with the ASN.1 names -
Make nameing consistent -
Depending on the choice: Reenable linter warnings -
Add missing instance attribute type annotations for all LDAP classes