Skip to content
Snippets Groups Projects
Commit 9bc7b9bd authored by Sven G. Brönstrup's avatar Sven G. Brönstrup
Browse files

Only suggert door properties on variables

parent 22ff0a5b
No related branches found
No related tags found
1 merge request!1Extended scripts support
Pipeline #10165 passed
......@@ -261,16 +261,16 @@ checkObjectProperty obj p@(Property name _) = case name of
"default" -> do
isBool p
requireProperty "door"
suggestProperty "door"
"persist" -> do
isBool p
requireProperty "door"
suggestProperty "door"
"openLayer" -> do
isString p
requireProperty "door"
suggestProperty "door"
"closeLayer" -> do
isString p
requireProperty "door"
suggestProperty "door"
"openSound" -> do
isString p
......@@ -278,10 +278,10 @@ checkObjectProperty obj p@(Property name _) = case name of
(dependsOn . Link)
(dependsOn . Local)
unless (containsProperty obj "soundRadius")
$ suggest "set \"soundRadius\" to a limit the door sound to a certain area\"."
unless (containsProperty obj "soundRadius") $
suggest "set \"soundRadius\" to a limit the door sound to a certain area\"."
requireProperty "door"
suggestProperty "door"
"closeSound" -> do
isString p
......@@ -289,21 +289,21 @@ checkObjectProperty obj p@(Property name _) = case name of
(dependsOn . Link)
(dependsOn . Local)
requireProperty "door"
unless (containsProperty obj "soundRadius") $
-- Do not suggest again if already suggested for openSound
unless (containsProperty obj "openSound") $
suggest "set \"soundRadius\" to a limit the door sound to a certain area\"."
suggestProperty "door"
"soundRadius" -> do
isInt p
unless (containsProperty obj "soundRadius")
$ suggest "set \"soundRadius\" to a limit the door sound to a certain area\"."
requireProperty "door"
_ -> warn $ "unknown object property " <> prettyprint name <> "."
where
requireProperty req = do
suggestProperty req = do
unless (containsProperty obj req) $
complain( "property " <> prettyprint req <> " is required by property " <> prettyprint name <> ".")
suggest( "property " <> prettyprint req <> " is suggested for property " <> prettyprint name <> ".")
-- | Checks a single (custom) property of an objectgroup layer
checkObjectGroupProperty :: Property -> LintWriter Layer
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment