Fixed behaviour if an invalid password is set in admin view, closes #28

tests/test_user.py

@@ -194,7 +194,6 @@ class TestUserViews(UffdTestCase):
 		self.assertEqual(user_updated.loginname, user_unupdated.loginname)
 		self.assertTrue(ldap.test_user_bind(user_updated.dn, 'newpassword'))
 
-	@unittest.skip('See #28')
 	def test_update_invalid_password(self):
 		user_unupdated = self.get_user()
 		r = self.client.get(path=url_for('user.show', uid=user_unupdated.uid), follow_redirects=True)

uffd/translations/de/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2021-07-30 21:03+0200\n"
+"POT-Creation-Date: 2021-07-30 21:15+0200\n"
 "PO-Revision-Date: 2021-05-25 21:18+0200\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: de\n"
@@ -1431,21 +1431,25 @@ msgstr "E-Mail-Adresse nicht valide"
 msgid "Display name does not meet requirements"
 msgstr "Anzeigename entspricht nicht den Anforderungen"
 
-#: uffd/user/views_user.py:75
+#: uffd/user/views_user.py:63
+msgid "Password is invalid"
+msgstr "Passwort ist ungültig"
+
+#: uffd/user/views_user.py:77
 msgid "Service user created"
 msgstr "Service-Account erstellt"
 
-#: uffd/user/views_user.py:78
+#: uffd/user/views_user.py:80
 msgid "User created. We sent the user a password reset link by mail"
 msgstr ""
 "Benutzer erstellt. E-Mail mit einem Link zum Setzen des Passworts wurde "
 "versendet."
 
-#: uffd/user/views_user.py:80
+#: uffd/user/views_user.py:82
 msgid "User updated"
 msgstr "Benutzer aktualisiert"
 
-#: uffd/user/views_user.py:91
+#: uffd/user/views_user.py:93
 msgid "Deleted user"
 msgstr "Benutzer gelöscht"
 

uffd/user/views_user.py

@@ -59,7 +59,9 @@ def update(uid=None):
 		return redirect(url_for('user.show', uid=uid))
 	new_password = request.form.get('password')
 	if uid is not None and new_password:
-		user.set_password(new_password)
+		if not user.set_password(new_password):
+			flash(_('Password is invalid'))
+			return redirect(url_for('user.show', uid=uid))
 	ldap.session.add(user)
 	user.roles.clear()
 	for role in Role.query.all():