Skip to content
Snippets Groups Projects
  1. Sep 10, 2021
  2. Sep 08, 2021
  3. Sep 05, 2021
    • Julian's avatar
      Refactor permission checking and differenciate login and selfservice access · e6df5bbe
      Julian authored
      Fixes #104.
      
      Replaced "group" keyword argument for login_required with "permission_check".
      Most views already define a *_acl_check function that returns whether the
      current user has the required permissions for use with register_navbar. The
      same function can now be passed to login_required as the "permission_check"
      argument.
      
      Differenciated login and selfservice access permissions. Previously
      ACL_SELFSERVICE_GROUP was required to login. Now ACL_ACCESS_GROUP is required
      to login and ACL_SELFSERVICE_GROUP is required to access selfservice functions
      (and to use role-granting invite links). A user with just ACL_ACCESS_GROUP can
      now login, access the services overview page and authenticate with OAuth2
      services he has access to, but not change his user attributes, password or
      roles/permissions.
      e6df5bbe
  4. Sep 04, 2021
    • Julian's avatar
      bf72b10d
    • Julian's avatar
      Removed TestUserViewsOLUserAsUser test cases · 0212237e
      Julian authored
      The test cases effectivly tested if the user_acl_check works which is already
      covered by other test cases.
      0212237e
    • Julian's avatar
      Dedicated error page for permission errors · 2d0ed84b
      Julian authored
      Prior to this change permission errors (i.e. the user is logged in but does
      not have a required group) were reported with flash('Access denied') and a
      redirect to the selfservice index page. This causes two problems: The error
      is reported with HTTP status 301/200 which is difficult to check for in tests.
      This can also cause redirect loops as soon as the selfservice uses more
      differentiated permission checks (see #104).
      
      With this change a dedicated error page is displayed in place the requested
      page and the HTTP status 403 is returned. This is implemented with
      flask's errorhandler concept for 403.
      2d0ed84b
  5. Sep 02, 2021
    • Julian's avatar
      Replace flask_oauthlib with plain oauthlib · 45d4598e
      Julian authored
      flask_oauthlib is no longer available in Debian Bullseye. It is only a
      wrapper around oauthlib, which is still available. While this change does
      increase the OAuth2 code size, it achieves compatability with both Debian
      Buster and Bullseye.
      
      Aside from error handling, this change has no noticable effects on OAuth2.0
      clients. In terms of error handling, a few cases that were not properly
      handled before now return appropriate error pages.
      
      Fixes #101
      45d4598e
  6. Aug 30, 2021
    • Julian's avatar
      Restrict password alphabet to SASLprep-safe ASCII subset · cb2d7f35
      Julian authored
      Prior to this change user passwords were not validated on change aside from
      their length, but validated on login/bind by ldap3 with SASLprep. Instead of
      using SASLprep on password change, this change restricts passwords to 7-bit
      ASCII without control characters. Control characters are forbidden by
      SASLprep. Multi-byte characters are uncommon in password, especially in those
      generated by password managers. This ensures that passwords are always
      SASLprep-safe without implementing the rather complex SASLprep algorithm. It
      also allows us to fully describe the alphabet restrictions in the relevant
      forms.
      
      Fixes #100
      cb2d7f35
    • Julian's avatar
      Catch LDAPSASLPrepError on login · 3f6a67ea
      Julian authored
      Ldap3 raises LDAPSASLPrepError on bind if the password contains characters
      forbidden by SASLPrep (string preperation/normalization algorithm for user
      names and passwords). Examples are carriage return ("\r") or newline ("\n")
      characters. See #100.
      3f6a67ea
  7. Aug 14, 2021
  8. Jul 30, 2021
  9. Jul 29, 2021
  10. Jul 26, 2021
  11. Jul 23, 2021
  12. Jun 22, 2021
  13. Jun 17, 2021
  14. Jun 13, 2021
  15. Jun 12, 2021
  16. May 21, 2021
  17. May 15, 2021
  18. May 14, 2021
  19. May 11, 2021
  20. May 01, 2021
  21. Apr 05, 2021
  22. Mar 14, 2021
  23. Feb 27, 2021
  24. Feb 23, 2021
  25. Feb 19, 2021
  26. Feb 15, 2021
  27. Jan 29, 2021
Loading